HawaiianSpork commented on code in PR #6998:
URL: https://github.com/apache/arrow-rs/pull/6998#discussion_r1926922172
##########
arrow-ipc/src/writer.rs:
##########
@@ -2615,6 +2615,35 @@ mod tests {
builder.finish()
}
+ #[test]
+ fn reencode_offsets_when_first_offset_is_not_zero() {
+ let original_list = generate_list_data::<i32>();
+ let original_data = original_list.into_data();
+ let slice_data = original_data.slice(75, 7);
+ let (new_offsets, original_start, length) =
reencode_offsets::<i32>(&slice_data.buffers()[0], &slice_data);
Review Comment:
Thanks for the test code in #7004 . I merged it in (I hope you don't mind)
and then added an end to end test that failed before the fix but passed
afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
