ViggoC commented on issue #41: URL: https://github.com/apache/arrow-java/issues/41#issuecomment-2610191259
Here is the result of VariableWidthVectorInlineValueBenchmarks before ``` Benchmark (step) Mode Cnt Score Error Units VariableWidthViewVectorInlineValueBenchmarks.setSafeFromArray 1 avgt 5 0.017 ± 0.001 ms/op VariableWidthViewVectorInlineValueBenchmarks.setSafeFromArray 2 avgt 5 0.018 ± 0.001 ms/op VariableWidthViewVectorInlineValueBenchmarks.setSafeFromArray 10 avgt 5 0.017 ± 0.001 ms/op VariableWidthViewVectorInlineValueBenchmarks.setSafeFromArray 40 avgt 5 0.017 ± 0.001 ms/op VariableWidthVectorInlineValueBenchmarks.setSafeFromArray 1 avgt 5 0.003 ± 0.001 ms/op VariableWidthVectorInlineValueBenchmarks.setSafeFromArray 2 avgt 5 0.005 ± 0.001 ms/op VariableWidthVectorInlineValueBenchmarks.setSafeFromArray 10 avgt 5 0.013 ± 0.001 ms/op VariableWidthVectorInlineValueBenchmarks.setSafeFromArray 40 avgt 5 0.044 ± 0.001 ms/op ``` after comment out setZero ``` VariableWidthViewVectorInlineValueBenchmarks.setSafeFromArray 1 avgt 5 0.002 ± 0.001 ms/op VariableWidthViewVectorInlineValueBenchmarks.setSafeFromArray 2 avgt 5 0.002 ± 0.001 ms/op VariableWidthViewVectorInlineValueBenchmarks.setSafeFromArray 10 avgt 5 0.002 ± 0.001 ms/op VariableWidthViewVectorInlineValueBenchmarks.setSafeFromArray 40 avgt 5 0.003 ± 0.001 ms/op ``` Checking first and then deciding whether to skip setZero, as done in the commit [30e595411e37b7ca2739c7005442ed7b329eeaea](https://github.com/apache/arrow/commit/30e595411e37b7ca2739c7005442ed7b329eeaea), does not work in the benchmark because the vector is always reused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
