alamb commented on code in PR #7013:
URL: https://github.com/apache/arrow-rs/pull/7013#discussion_r1929222841
##########
arrow-buffer/src/builder/null.rs:
##########
@@ -134,6 +133,42 @@ impl NullBufferBuilder {
}
}
+ /// Returns the capacity of the buffer
+ #[inline]
+ pub fn capacity(&self) -> usize {
+ if let Some(buf) = self.bitmap_builder.as_ref() {
+ buf.capacity()
+ } else {
+ 0
+ }
+ }
+
+ /// Gets a bit in the buffer at `index`
+ #[inline]
+ pub fn is_valid(&mut self, index: usize) -> bool {
+ if let Some(buf) = self.bitmap_builder.as_mut() {
+ buf.get_bit(index)
+ } else {
+ true
+ }
+ }
+
+ /// Truncates the builder to the given length
+ ///
+ /// If `len` is greater than the buffer's current length, this has no
effect
+ #[inline]
+ pub fn truncate(&mut self, len: usize) {
+ if len > self.len {
+ return;
+ }
Review Comment:
You are (of course) correct. This is a great test and find
I took the liberty of pushing a commit to this branch that includes this
test case (and will fail CI until it is fixed so block this PR from merging)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
