Jefffrey commented on PR #6643: URL: https://github.com/apache/arrow-rs/pull/6643#issuecomment-2614623717
> Generally looks good to me. We'll see if can get another opinion on the API design (possibly @alamb or @tustvold?) > > > Re: option overlapping: Yeah, without a breaking API change, I see three options: > > > > 1. Describe that strict_mode and explicit_nulls are effectively determined by struct_mode in documentation. (As is) > > 2. Document that the "wrong" settings for strict_mode/explicit_nulls and struct_mode is not allowed; panic in that case. > > 3. Explicitly set strict_mode/explicit_nulls when struct_mode is set, and checkl when struct_mode/explicit_nulls is set. And document. > > > > I think 3 is weird and probably leaves a footgun for later developers. I don't have a strong opinion between either 1 or 2. > > I also lean towards option 1 (current state of the PR); for future we could consider patterns like type-state builders when not constrained by not having breaking changes to the API. Raised #7025 for future reference -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
