kou commented on code in PR #45353:
URL: https://github.com/apache/arrow/pull/45353#discussion_r1929927016
##########
c_glib/test/test-record-batch.rb:
##########
@@ -189,5 +189,37 @@ def test_serialize
assert_equal(@record_batch,
input_stream.read_record_batch(@record_batch.schema))
end
+
+ sub_test_case("#validate") do
+ def setup
+ @id_field = Arrow::Field.new("id",Arrow::UInt8DataType.new)
+ @name_field = Arrow::Field.new("name",Arrow::StringDataType.new)
+ @schema = Arrow::Schema.new([@id_field,@name_field])
+
+ @id_value = build_uint_array([1])
+ @name_value = build_string_array(["abc"])
+ @values = [@id_value,@name_value]
+ end
+
+ def test_valid
+ nrows = @id_value.length
+ record_batch = Arrow::RecordBatch.new(@schema,nrows,@values)
Review Comment:
```suggestion
n_rows = @id_value.length
record_batch = Arrow::RecordBatch.new(@schema, n_rows, @values)
```
##########
c_glib/test/test-record-batch.rb:
##########
@@ -189,5 +189,37 @@ def test_serialize
assert_equal(@record_batch,
input_stream.read_record_batch(@record_batch.schema))
end
+
+ sub_test_case("#validate") do
+ def setup
+ @id_field = Arrow::Field.new("id",Arrow::UInt8DataType.new)
+ @name_field = Arrow::Field.new("name",Arrow::StringDataType.new)
+ @schema = Arrow::Schema.new([@id_field,@name_field])
+
+ @id_value = build_uint_array([1])
+ @name_value = build_string_array(["abc"])
+ @values = [@id_value,@name_value]
Review Comment:
```suggestion
@values = [@id_value, @name_value]
```
##########
c_glib/test/test-record-batch.rb:
##########
@@ -189,5 +189,37 @@ def test_serialize
assert_equal(@record_batch,
input_stream.read_record_batch(@record_batch.schema))
end
+
+ sub_test_case("#validate") do
+ def setup
+ @id_field = Arrow::Field.new("id",Arrow::UInt8DataType.new)
+ @name_field = Arrow::Field.new("name",Arrow::StringDataType.new)
+ @schema = Arrow::Schema.new([@id_field,@name_field])
Review Comment:
```suggestion
@id_field = Arrow::Field.new("id", Arrow::UInt8DataType.new)
@name_field = Arrow::Field.new("name", Arrow::StringDataType.new)
@schema = Arrow::Schema.new([@id_field, @name_field])
```
##########
c_glib/test/test-record-batch.rb:
##########
@@ -189,5 +189,37 @@ def test_serialize
assert_equal(@record_batch,
input_stream.read_record_batch(@record_batch.schema))
end
+
+ sub_test_case("#validate") do
+ def setup
+ @id_field = Arrow::Field.new("id",Arrow::UInt8DataType.new)
+ @name_field = Arrow::Field.new("name",Arrow::StringDataType.new)
+ @schema = Arrow::Schema.new([@id_field,@name_field])
+
+ @id_value = build_uint_array([1])
+ @name_value = build_string_array(["abc"])
+ @values = [@id_value,@name_value]
+ end
+
+ def test_valid
+ nrows = @id_value.length
+ record_batch = Arrow::RecordBatch.new(@schema,nrows,@values)
+
+ assert do
+ record_batch.validate
+ end
+ end
+
+ def test_invalid
+ message = "[record-batch][validate]: Invalid: " +
+ "Number of rows in column 0 did not match batch: 1 vs 2"
+ nrows = @id_value.length + 1 # incorrect num
+
+ record_batch = Arrow::RecordBatch.new(@schema,nrows,@values)
Review Comment:
```suggestion
n_rows = @id_value.length + 1 # incorrect number of rows
record_batch = Arrow::RecordBatch.new(@schema, n_rows, @values)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
