alamb commented on code in PR #7028:
URL: https://github.com/apache/arrow-rs/pull/7028#discussion_r1930330307
##########
arrow-ipc/src/reader.rs:
##########
@@ -65,7 +65,7 @@ fn read_buffer(
(false, Some(decompressor)) =>
decompressor.decompress_to_buffer(&buf_data),
}
}
-impl ArrayReader<'_> {
+impl RecordBatchDecoder<'_> {
Review Comment:
The major change is to rename this per @tustvold 's suggestion:
- https://github.com/apache/arrow-rs/pull/7006/files#r1929568795
##########
arrow-ipc/src/reader.rs:
##########
@@ -83,18 +83,17 @@ impl ArrayReader<'_> {
field: &Field,
variadic_counts: &mut VecDeque<i64>,
) -> Result<ArrayRef, ArrowError> {
- let reader = self;
Review Comment:
removed `reader` alias as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
