velvia commented on a change in pull request #9773:
URL: https://github.com/apache/arrow/pull/9773#discussion_r600023805
##########
File path: rust/datafusion/src/physical_plan/hash_join.rs
##########
@@ -656,42 +656,20 @@ fn equal_rows(
.zip(right_arrays)
.all(|(l, r)| match l.data_type() {
DataType::Null => true,
- DataType::Boolean => {
- equal_rows_elem!(BooleanArray, l, r, left, right)
- }
- DataType::Int8 => {
- equal_rows_elem!(Int8Array, l, r, left, right)
- }
- DataType::Int16 => {
- equal_rows_elem!(Int16Array, l, r, left, right)
- }
- DataType::Int32 => {
- equal_rows_elem!(Int32Array, l, r, left, right)
- }
- DataType::Int64 => {
- equal_rows_elem!(Int64Array, l, r, left, right)
- }
- DataType::UInt8 => {
- equal_rows_elem!(UInt8Array, l, r, left, right)
- }
- DataType::UInt16 => {
- equal_rows_elem!(UInt16Array, l, r, left, right)
- }
- DataType::UInt32 => {
- equal_rows_elem!(UInt32Array, l, r, left, right)
- }
- DataType::UInt64 => {
- equal_rows_elem!(UInt64Array, l, r, left, right)
- }
+ DataType::Boolean => equal_rows_elem!(BooleanArray, l, r, left,
right),
Review comment:
This is what I'm running, is it too old?
`nightly-2020-11-25-x86_64-apple-darwin (default)`
Should arrow project have a `rust-toolchain` to specify what version of Rust
to run on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
