rluvaton commented on code in PR #7037:
URL: https://github.com/apache/arrow-rs/pull/7037#discussion_r1932374026
##########
arrow-select/src/concat.rs:
##########
@@ -135,13 +135,16 @@ fn concat_lists<OffsetSize: OffsetSizeTrait>(
) -> Result<ArrayRef, ArrowError> {
let mut output_len = 0;
let mut list_has_nulls = false;
+ let mut list_has_slices = false;
let lists = arrays
.iter()
.map(|x| x.as_list::<OffsetSize>())
.inspect(|l| {
output_len += l.len();
list_has_nulls |= l.null_count() != 0;
+ list_has_slices |= l.offsets()[0].as_usize() > 0
+ || l.offsets().last().unwrap().as_usize() < l.values().len();
Review Comment:
```suggestion
list_has_slices |= l.offsets()[0] > OffsetSize::zero()
|| l.offsets().last().unwrap().as_usize() < l.values().len();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
