alamb commented on PR #7009: URL: https://github.com/apache/arrow-rs/pull/7009#issuecomment-2621500299
> 2. Change the Github check so those two files are excluded from the 'up-to-date' check. Basically, have faith that if the change author correctly regenerated the other proto files, then the file descriptor set files were also correctly regenerated. I think there would be a lot of trust in this option. However, it would be easy. Something like (untested): git diff --exit-code -- . ':(exclude)*.bin' [here](https://github.com/apache/arrow-rs/blob/2bd43e99da6258926927cf2904e1eac815542b8f/.github/workflows/arrow_flight.yml#L77) This sounds like a pragmatic solution to me -- is there some way we can verify that the checked in descriptor matches the rebuilt one (not byte-for-byte identical but some sort of semantic check 🤔 ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
