Dandandan commented on issue #7014: URL: https://github.com/apache/arrow-rs/issues/7014#issuecomment-2623843862
There are places that still do `std::str::from_utf8` like `validate_string_view`. https://github.com/apache/arrow-rs/blob/3bf29a2c7474e59722d885cd11fafd0dca13a28e/arrow-data/src/byte_view.rs#L145 This still has `std::str::from_utf8` ? I got it from @alamb profile in https://github.com/apache/datafusion/issues/13983#issuecomment-2613378310 where it has ~5% of samples. I think there is also some other places which can benefit by a bit from this (e.g. reading csv/json, casting...). https://github.com/search?q=repo%3Aapache%2Farrow-rs%20std%3A%3Astr%3A%3Afrom_utf8&type=code > I am embarassed to admit I missed the StringView one -- I will make a PR to switch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
