WillAyd commented on code in PR #709:
URL: https://github.com/apache/arrow-nanoarrow/pull/709#discussion_r1935982513
##########
src/nanoarrow/hpp/view_test.cc:
##########
@@ -82,6 +82,58 @@ TEST(NanoarrowHppTest, NanoarrowHppViewArrayAsBytesTest) {
}
}
+class BinaryViewTypeTestFixture : public ::testing::TestWithParam<enum
ArrowType> {
+ protected:
+ enum ArrowType data_type;
+};
+
+TEST_P(BinaryViewTypeTestFixture, NanoarrowHppViewBinaryViewArrayAsBytesTest) {
+ using namespace nanoarrow::literals;
+
+ nanoarrow::UniqueArray array{};
+ ASSERT_EQ(ArrowArrayInitFromType(array.get(), GetParam()), NANOARROW_OK);
+ ASSERT_EQ(ArrowArrayStartAppending(array.get()), NANOARROW_OK);
+
+ ASSERT_EQ(ArrowArrayAppendString(array.get(), "foo"_asv), NANOARROW_OK);
+ ASSERT_EQ(ArrowArrayAppendNull(array.get(), 1), NANOARROW_OK);
+ ASSERT_EQ(ArrowArrayAppendString(array.get(),
"this_string_is_longer_than_inline"_asv),
+ NANOARROW_OK);
+ ASSERT_EQ(ArrowArrayAppendNull(array.get(), 1), NANOARROW_OK);
+ ASSERT_EQ(ArrowArrayFinishBuildingDefault(array.get(), nullptr),
NANOARROW_OK);
+
+ ArrowStringView expected[] = {"foo"_asv, ""_asv,
+ "this_string_is_longer_than_inline"_asv,
""_asv,
+ "here_is_another_string"_asv};
+
+ nanoarrow::UniqueArrayView array_view{};
+ ArrowArrayViewInitFromType(array_view.get(), GetParam());
+ ASSERT_EQ(ArrowArrayViewSetArray(array_view.get(), array.get(), nullptr),
NANOARROW_OK);
+
+ int i = 0;
+ for (auto slot : nanoarrow::ViewBinaryViewArrayAsBytes(array.get())) {
+ if (i == 1 || i == 3) {
+ EXPECT_EQ(slot, nanoarrow::NA);
+ } else {
+ EXPECT_EQ(slot, expected[i]);
+ }
+ ++i;
+ }
+
+ i = 0;
+ for (auto slot : nanoarrow::ViewBinaryViewArrayAsBytes(array_view.get())) {
+ if (i == 1 || i == 3) {
+ EXPECT_EQ(slot, nanoarrow::NA);
+ } else {
+ EXPECT_EQ(slot, expected[i]);
+ }
+ ++i;
+ }
Review Comment:
Nice idea - added some parametrization for that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
