kou commented on code in PR #44989: URL: https://github.com/apache/arrow/pull/44989#discussion_r1936510613
########## cpp/CMakeLists.txt: ########## @@ -15,9 +15,14 @@ # specific language governing permissions and limitations # under the License. -cmake_minimum_required(VERSION 3.16) +cmake_minimum_required(VERSION 3.25) message(STATUS "Building using CMake version: ${CMAKE_VERSION}") +# https://cmake.org/cmake/help/latest/policy/CMP0126.html +# +# set(CACHE) does not remove a normal variable of the same name. Review Comment: Ah, sorry. It should be `unset(ZLIB_LIBRARY)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org