jbonofre commented on code in PR #578: URL: https://github.com/apache/arrow-java/pull/578#discussion_r1938413707
########## LICENSE.txt: ########## @@ -202,16 +202,21 @@ limitations under the License. -------------------------------------------------------------------------------- -vector/src/main/java/org/apache/arrow/vector/util/IntObjectHashMap.java -vector/src/main/java/org/apache/arrow/vector/util/IntObjectMap.java +This product includes code from Netty 4.1.117.Final: Review Comment: Unfortunately (or not 😄 ), yes, It's important to specify the version of the dependency as licenses sometimes change as product versions change. Also the `NOTICE` can change from a version to another. So, it's better to document to actual version bundled in our distributed jar. So source distribution, we should document the version where the code has been copied from. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org