zanmato1984 commented on issue #45393: URL: https://github.com/apache/arrow/issues/45393#issuecomment-2629271372
OK, I managed to learn some of our R benchmarking code and re-interpret the benchmark result. This is indeed a regression/bug. The comparison of the benchmark is done via https://github.com/voltrondata-labs/arrowbench/blob/deacdebc64bb5c04f8976138c45db96710e56e77/R/bm-tpc-h.R#L107C24-L107C38: ``` all_equal_out <- waldo::compare(result, answer, tolerance = 0.01) ``` And according to the waldo doc (https://waldo.r-lib.org/), the "old" in the report is actually the first argument (`result`) and the "new" the second (`answer`). So apparently the bug turned the all-zero `l_shippriority` column into some arbitrary non-zero values. I'll definitely look into it once I'm back. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
