alamb commented on PR #6035: URL: https://github.com/apache/arrow-rs/pull/6035#issuecomment-2631388693
> @alamb since hashbrown's HashTable is now the same as std's HashMap, I wonder if we can drop hashboarn dependency and use std's HashMap. > > That said, it happens after [Rust 1.36](https://github.com/rust-lang/hashbrown) and arrow-rs requires a MSRV >= 1.62. So it would be always valid. > > The only downside is that in no-std environment there is no std's HashMap, but IIUC arrow-rs don't be aimed at supporting no-std? > Since Rust 1.36, this is now the HashMap implementation for the Rust standard library. However you may still want to use this crate instead since it works in environments without std, such as embedded systems and kernels. https://crates.io/crates/hashbrown Seems like a reasonable thing to me to try (use HashMap rather than hashbrown) However, I think there are parts of arrow that use the lower level APIs (like RawTable) so we might not be able to remove the dependency entirely -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
