pitrou commented on a change in pull request #9751:
URL: https://github.com/apache/arrow/pull/9751#discussion_r600408166
##########
File path: cpp/src/arrow/compute/kernels/scalar_cast_numeric.cc
##########
@@ -606,17 +642,32 @@ std::shared_ptr<CastFunction> GetCastToDecimal128() {
// We resolve the output type of this kernel from the CastOptions
DCHECK_OK(
func->AddKernel(Type::DECIMAL128, {InputType(Type::DECIMAL128)},
sig_out_ty, exec));
+ exec = CastFunctor<Decimal128Type, Decimal256Type>::Exec;
+ DCHECK_OK(
+ func->AddKernel(Type::DECIMAL256, {InputType(Type::DECIMAL256)},
sig_out_ty, exec));
return func;
}
std::shared_ptr<CastFunction> GetCastToDecimal256() {
OutputType sig_out_ty(ResolveOutputFromOptions);
auto func = std::make_shared<CastFunction>("cast_decimal256",
Type::DECIMAL256);
- // Needed for Parquet conversion. Full implementation is ARROW-10606
- // tracks full implementation.
+ // Needed for Parquet conversion.
Review comment:
I don't think this comment is still useful. These are just the same
casts as for `Decimal128`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
