pitrou commented on code in PR #45392: URL: https://github.com/apache/arrow/pull/45392#discussion_r1940917729
########## python/pyarrow/_compute.pxd: ########## @@ -65,6 +65,8 @@ cdef CExpression _true cdef CFieldRef _ensure_field_ref(value) except * +cdef vector[CSortKey] unwrap_sort_keys(sort_keys, allow_str=*) Review Comment: Should be `except *` since it calls `_ensure_field_ref` which can raise an exception. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
