kou commented on code in PR #45424:
URL: https://github.com/apache/arrow/pull/45424#discussion_r1942165470


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1256,14 +1256,19 @@ endif()
 # - Gandiva has a compile-time (header-only) dependency on Boost, not runtime.
 # - Tests need Boost at runtime.
 # - S3FS and Flight benchmarks need Boost at runtime.
+# - arrow_testing uses boost::filesystem. So arrow_testing requires

Review Comment:
   Ah, wait. We may be able to replace `boost::filesystem` with 
`std::filesystem`. We don't need to use `boost::filesystem` by replacing 
`boost::filesystem` with `std::filesystem` here: 
https://github.com/apache/arrow/blob/1567be0d74c5ee90c3d989f6fcefb32c402a736c/cpp/src/arrow/testing/process.cc#L251-L283



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to