irenjj commented on code in PR #7065:
URL: https://github.com/apache/arrow-rs/pull/7065#discussion_r1942246993
##########
arrow-cast/src/cast/list.rs:
##########
@@ -88,11 +88,16 @@ where
let mut mutable = MutableArrayData::new(vec![&values], nullable, cap);
// The end position in values of the last incorrectly-sized list slice
let mut last_pos = 0;
+ let mut null_first = false;
Review Comment:
Thanks @Jefffrey for your review, in my local testing, `null_first` can
identify both None and empty vec (the name `null_first` might be a bit
misleading). My idea is to use `null_first` to prevent entering the `let values
= match last_pos { 0 => }` situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
