WillAyd commented on code in PR #45272:
URL: https://github.com/apache/arrow/pull/45272#discussion_r1943227326
##########
cpp/src/arrow/compute/kernels/scalar_compare.cc:
##########
@@ -445,6 +445,14 @@ std::shared_ptr<ScalarFunction>
MakeCompareFunction(std::string name, FunctionDo
DCHECK_OK(func->AddKernel({ty, ty}, boolean(), std::move(exec)));
}
+ if constexpr (std::is_same_v<Op, Equal> || std::is_same_v<Op, NotEqual>) {
+ for (const auto id : {Type::LIST, Type::LARGE_LIST}) {
+ auto exec = GenerateList<applicator::ScalarBinaryEqualTypes,
BooleanType, Op>(id);
Review Comment:
OK took a closer look at this. So AFAICT the `RangeDataEqualsImpl` returns a
scalar bool value, rather than an array of booleans like we would need in the
result here. That class is also private to the `compare.cc` module and doesn't
expose any suitable entrypoint in `compare.h` that I think would work here.
Are you thinking we should refactor the `RangeDataEqualsImpl` to support
vector functions and move it to make it accessible to the compute module, or do
you think we should just create a dedicated class drawing some inspiration from
it in `scalar_compute.cc`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
