singh1203 commented on PR #263: URL: https://github.com/apache/arrow-go/pull/263#issuecomment-2637559377
> > @zeroshade I made changes by adding a hook, which you can see [here](https://github.com/singh1203/arrow-go/actions/runs/13046944649/job/36399021645). This raises the question: do I need to commit the changed files after running pre-commit cmd locally? > > That's the way it would work, yes. I'm not sure if we'd want it to automatically commit the changed files. Yes you were right I need to commit, and also, instead of hook, I chose to go ahead with `go fmt` cmd since that pre-commit hook is more being maintained. Aside from that, I think we can run the pre-commit run before pushing rather than autocommitting. @kou Any thoughts for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
