CurtHagenlocher commented on code in PR #7062:
URL: https://github.com/apache/arrow-rs/pull/7062#discussion_r1944857775


##########
arrow-cast/src/cast/dictionary.rs:
##########
@@ -359,6 +329,34 @@ where
     Ok(Arc::new(b.finish()))
 }
 
+pub(crate) fn pack_decimal_to_dictionary<K, D, M>(
+    array: &dyn Array,
+    dict_value_type: &DataType,
+    precision: u8,
+    scale: i8,
+    cast_options: &CastOptions,
+) -> Result<ArrayRef, ArrowError>
+where
+    K: ArrowDictionaryKeyType,
+    D: DecimalType + ArrowPrimitiveType<Native = M>,
+    M: ArrowNativeTypeOp + DecimalCast,

Review Comment:
   I suspect some of the extra generic arguments are required once I add 
decimal32 and decimal64, but I'll try it and see.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to