EnricoMi commented on code in PR #44990:
URL: https://github.com/apache/arrow/pull/44990#discussion_r1945058482
##########
cpp/src/parquet/column_reader.cc:
##########
@@ -333,14 +340,16 @@ void SerializedPageReader::InitDecryption() {
// Prepare the AAD for quick update later.
if (crypto_ctx_.data_decryptor != nullptr) {
ARROW_DCHECK(!crypto_ctx_.data_decryptor->file_aad().empty());
+ data_decryptor_ = std::make_shared<Decryptor>(*crypto_ctx_.data_decryptor);
Review Comment:
You are right,
data_decryptor_ =
std::make_shared<Decryptor>(*crypto_ctx_.data_decryptor)
could be simplified to
data_decryptor_ = crypto_ctx_.data_decryptor
which should increment the reference counter and therefore be equivalent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
