alamb commented on code in PR #7089:
URL: https://github.com/apache/arrow-rs/pull/7089#discussion_r1945293119
##########
arrow-buffer/src/builder/null.rs:
##########
@@ -217,7 +217,7 @@ impl NullBufferBuilder {
self.bitmap_builder.as_mut().map(|b| b.as_slice_mut())
}
- /// Return the allocated size of this builder, in bytes, useful for memory
accounting.
+ /// Return the allocated size of this builder, in bits, useful for memory
accounting.
Review Comment:
This documentation is wrong -- as it uses `capacity()` directly which
returns a size in bits
I actually think it would be better if we had a function that returned
allocated size in bytes (maybe we can deprecate this one and make a new one
like `allocated_bytes()` or something for clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
