alamb commented on code in PR #7029:
URL: https://github.com/apache/arrow-rs/pull/7029#discussion_r1945328300
##########
arrow-ipc/src/reader.rs:
##########
@@ -85,16 +85,15 @@ impl RecordBatchDecoder<'_> {
) -> Result<ArrayRef, ArrowError> {
let data_type = field.data_type();
match data_type {
- Utf8 | Binary | LargeBinary | LargeUtf8 => create_primitive_array(
- self.next_node(field)?,
- data_type,
- &[
+ Utf8 | Binary | LargeBinary | LargeUtf8 => {
+ let field_node = self.next_node(field)?;
+ let buffers = [
self.next_buffer()?,
self.next_buffer()?,
self.next_buffer()?,
- ],
- self.require_alignment,
- ),
+ ];
+ self.create_primitive_array(field_node, data_type, &buffers)
Review Comment:
the idea here is to simply call `self.` instead of free functions like
`create_primitive_array`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
