ianmcook commented on a change in pull request #9798:
URL: https://github.com/apache/arrow/pull/9798#discussion_r600751291
##########
File path: r/R/dplyr.R
##########
@@ -216,6 +215,52 @@ column_select <- function(.data, ..., .FUN = vars_select) {
.data
}
+relocate.arrow_dplyr_query <- function(.data, ..., .before = NULL, .after =
NULL) {
+ .data <- arrow_dplyr_query(.data)
+
+ # TODO: look for unsupported tidyselect selection helpers in exprs(...),
+ # .before, and .after and throw an error if detected
Review comment:
Currently when expressions in `relocate()` use unsupported tidyselect
helpers, sometimes they silently do nothing and other times they fail with
unhelpful error messages. Should I dig into this now or create a Jira for
follow-up later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
