etseidl commented on issue #7040: URL: https://github.com/apache/arrow-rs/issues/7040#issuecomment-2643014875
> > what do you think of special casing casts to truncated integer types? Is the speedup worth the extra code > > IMO given the following: > > * The consensus appears to be that this is a writer bug > * It doesn't appear any real system produces such files outside of tests > > I'd personally be inclined to do nothing, it seems unnecessary to add complexity if this is purely a theoretical problem. I guess I got off on a bit of a tangent here. I was asking not so much about handling the bad data, but rather the serendipitous finding that the existing code is quite slow doing casts from 32 bits down to 8 or 16. That can be raised in a separate issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
