trungda commented on code in PR #7087:
URL: https://github.com/apache/arrow-rs/pull/7087#discussion_r1945276088
##########
parquet/src/file/serialized_reader.rs:
##########
@@ -526,18 +526,19 @@ impl<R: ChunkReader> SerializedPageReader<R> {
SerializedPageReader::new_with_properties(reader, meta, total_rows,
page_locations, props)
}
- /// Creates a new serialized page with custom options.
+ /// Creates a new serialized page reader with custom options.
+ /// Note: The first page in `page_locations` (if available)
+ /// must be the first data page to infer the dictionary page's location.
Review Comment:
Is there a way to enforce or return error early when a user doesn't follow
this? I believe, currently, the reader will panic if the first page location is
not the first data page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
