rok commented on code in PR #6637:
URL: https://github.com/apache/arrow-rs/pull/6637#discussion_r1948939962
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -379,10 +380,23 @@ impl ArrowReaderMetadata {
/// If `options` has [`ArrowReaderOptions::with_page_index`] true, but
/// `Self::metadata` is missing the page index, this function will attempt
/// to load the page index by making an object store request.
- pub fn load<T: ChunkReader>(reader: &T, options: ArrowReaderOptions) ->
Result<Self> {
- let metadata = ParquetMetaDataReader::new()
- .with_page_indexes(options.page_index)
+ ///
+ /// If encryption is enabled and the file is encrypted, the
+ /// `file_decryption_properties` must be provided.
+ pub fn load<T: ChunkReader>(
+ reader: &T,
+ options: ArrowReaderOptions,
+ #[cfg(feature = "encryption")] file_decryption_properties: Option<
+ &FileDecryptionProperties,
Review Comment:
Changed as suggested. It does make for cleaner API, but feels kinda wrong
due to naming. Maybe there's other opinions on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
