tustvold commented on issue #7119: URL: https://github.com/apache/arrow-rs/issues/7119#issuecomment-2652226633
Given that `Array::is_null` refers to logical_nulls, I think adding the below to `Array::logical_nulls` should be sufficient > WARNING: The logical nullability of a nested column is the union of logical nulls for all ancestors, which this method does not cover. See [NullBuffer::union](https://docs.rs/arrow/latest/arrow/buffer/struct.NullBuffer.html#method.union). > [StructArray::into_parts](https://docs.rs/arrow/latest/arrow/array/struct.StructArray.html#method.into_parts) should also be straightforward, something like: > Maybe also [StructArray::try_new](https://docs.rs/arrow/latest/arrow/array/struct.StructArray.html#method.try_new)? I'm not sure about the need for these, given this null buffer is literally just the null buffer for that StructArray, and makes no claims to the contrary. I think what might help is adding a representation section, similar to we have for [ListArray](https://docs.rs/arrow-array/latest/arrow_array/array/struct.GenericListArray.html#representation) as added by @alamb in https://github.com/apache/arrow-rs/pull/7039. This could clearly show that null slots are arbitrary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
