rshkv commented on code in PR #7101:
URL: https://github.com/apache/arrow-rs/pull/7101#discussion_r1951745762
##########
arrow-array/src/builder/map_builder.rs:
##########
@@ -107,13 +108,29 @@ impl<K: ArrayBuilder, V: ArrayBuilder> MapBuilder<K, V> {
field_names: field_names.unwrap_or_default(),
key_builder,
value_builder,
+ key_field: None,
value_field: None,
}
}
/// Override the field passed to [`MapBuilder::new`]
///
- /// By default a nullable field is created with the name `values`
+ /// By default, a nullable field is created with the name `keys`
+ ///
+ /// Panics if the given field is nullable as map keys are not allowed to
be null
+ ///
+ /// Note: [`Self::finish`] and [`Self::finish_cloned`] will panic if the
+ /// field's data type does not match that of `K`
Review Comment:
Oops, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
