shuozel commented on issue #7121: URL: https://github.com/apache/arrow-rs/issues/7121#issuecomment-2652610025
It seems the `NullBufferBuilder` is calling the `BooleanBufferBuilder.capacity()` here [1], and we are directly returning the capacity in bits returend by the BooleanBufferBuilder. Just wanna confirm, we should only make the change to the `NullBufferBuilder.capacity()` to return the capacity in bytes and leave the `BooleanBufferBuilder.capacity()` unchanged to return the capacity in bits. Please correct me if my understanding is incorrect. [1]: https://github.com/apache/arrow-rs/blob/27d2a7510d75163f1d8cb430666662f3bef8bbea/arrow-buffer/src/builder/null.rs#L224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
