jecsand838 commented on PR #6965: URL: https://github.com/apache/arrow-rs/pull/6965#issuecomment-2652692978
> Thank you for this, I wonder if there is some way we might break this up into smaller pieces. A single 5000 line diff is not something I can realistically review... @tustvold I completely understand, my apologies about that! Roughly 3500 lines of the diff are tests and ~1000 lines of that 3500 is test code in `reader/mod.rs`. If I removed all the tests we added save for the ones in `reader/mod.rs`, I could probably get this diff down to ~2500 lines (with ~1000 lines of that still tests). I know that is still large, but would it be acceptable? We can definitely add those tests back in a future PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
