mbrobbel commented on PR #7122: URL: https://github.com/apache/arrow-rs/pull/7122#issuecomment-2653523012
> I personally think this is a bug and therefore not a breaking change, but curious what others think > > E.g. @alamb I think we should mark this as a breaking change. I agree that it was wrong to return number of bits here, but the docs state that this returns bits, so the current behaviour is as expected for users. If this said bytes and returned bits (or the other way around) I think this would be a non-breaking bug fix, but now we're changing semantics, which is not expected for a non-breaking change. An alternative would be to mark this as deprecated and introduce another method that returns bytes. Then this can be removed, after which we can deprecate the new method and re-introduce this as bytes again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
