pitrou commented on code in PR #45515:
URL: https://github.com/apache/arrow/pull/45515#discussion_r1952933863
##########
cpp/src/arrow/compute/key_map_internal.h:
##########
@@ -220,6 +257,12 @@ class ARROW_EXPORT SwissTable {
return bits_stamp_;
}
+ static uint32_t group_id_mask_from_num_groupid_bits(int64_t
num_groupid_bits) {
+ return static_cast<uint32_t>((1ULL << num_groupid_bits) - 1);
+ }
+
+ static constexpr int bytes_status_in_block_ = 8;
Review Comment:
Usually, compile-time constants should follow the naming convention
`kBytesStatusInBlock`. Perhaps we can have a renaming pass in this PR or
another one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
