adriangb commented on PR #7015: URL: https://github.com/apache/arrow-rs/pull/7015#issuecomment-2655553947
I've started trying to replace our vendored version with this + a hook to handle the JSON union and have a couple of notes: 1. In order to handle unions we need `make_encoder` to be public: the union will need to delegate to `make_encoder` for it's children. 2. Handling dictionary types is annoying, I would consider making `DictionaryEncoder` public. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
