etseidl commented on code in PR #6637:
URL: https://github.com/apache/arrow-rs/pull/6637#discussion_r1955299058
##########
parquet/src/arrow/async_reader/mod.rs:
##########
@@ -103,7 +108,13 @@ pub trait AsyncFileReader: Send {
/// Provides asynchronous access to the [`ParquetMetaData`] of a parquet
file,
/// allowing fine-grained control over how metadata is sourced, in
particular allowing
/// for caching, pre-fetching, catalog metadata, etc...
- fn get_metadata(&mut self) -> BoxFuture<'_, Result<Arc<ParquetMetaData>>>;
+ /// If data is encrypted, the [`FileDecryptionProperties`] should be
provided.
Review Comment:
Same comment about experimental features showing up in public docs
##########
parquet/src/arrow/async_reader/store.rs:
##########
@@ -23,6 +23,7 @@ use object_store::{path::Path, ObjectMeta, ObjectStore};
use tokio::runtime::Handle;
use crate::arrow::async_reader::AsyncFileReader;
+use crate::encryption::decryption::FileDecryptionProperties;
Review Comment:
```suggestion
#[cfg(feature = "encryption")]
use crate::encryption::decryption::FileDecryptionProperties;
```
should this be gated?
##########
parquet/src/arrow/async_reader/mod.rs:
##########
@@ -343,8 +386,8 @@ impl<T: AsyncFileReader + Send + 'static>
ParquetRecordBatchStreamBuilder<T> {
Self::new_with_options(input, Default::default()).await
}
- /// Create a new [`ParquetRecordBatchStreamBuilder`] with the provided
async source
- /// and [`ArrowReaderOptions`]
+ /// Create a new [`ParquetRecordBatchStreamBuilder`] with the provided
async source,
+ /// [`ArrowReaderOptions`] and [`FileDecryptionProperties`] if the data is
encrypted.
Review Comment:
another experimental in public instance
##########
parquet/src/arrow/async_reader/mod.rs:
##########
@@ -201,7 +243,8 @@ pub struct AsyncReader<T>(T);
///
/// This builder handles reading the parquet file metadata, allowing consumers
/// to use this information to select what specific columns, row groups, etc...
-/// they wish to be read by the resulting stream
+/// they wish to be read by the resulting stream. If footer or columns are
encrypted
+/// [`FileDecryptionProperties`] should be provided.
Review Comment:
I'm a little concerned here that something marked "experimental" is being
referenced from the public API docs. When I render the docs locally
`FileDecryptionProperties` is not a link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
