lidavidm commented on code in PR #2530:
URL: https://github.com/apache/arrow-adbc/pull/2530#discussion_r1957449436


##########
docs/source/driver/jdbc.rst:
##########
@@ -57,7 +57,7 @@ or an instance of a ``javax.sql.DataSource`` as the
       .. code-block:: java
 
          final Map<String, Object> parameters = new HashMap<>();
-         parameters.put(AdbcDriver.PARAM_URL, 
"jdbc:postgresql://localhost:5432/postgres");
+         parameters.put(AdbcDriver.PARAM_URI.key, 
"jdbc:postgresql://localhost:5432/postgres");

Review Comment:
   And ditto below



##########
docs/source/driver/jdbc.rst:
##########
@@ -57,7 +57,7 @@ or an instance of a ``javax.sql.DataSource`` as the
       .. code-block:: java
 
          final Map<String, Object> parameters = new HashMap<>();
-         parameters.put(AdbcDriver.PARAM_URL, 
"jdbc:postgresql://localhost:5432/postgres");
+         parameters.put(AdbcDriver.PARAM_URI.key, 
"jdbc:postgresql://localhost:5432/postgres");

Review Comment:
   ```suggestion
            AdbcDriver.PARAM_URI.set(parameters, 
"jdbc:postgresql://localhost:5432/postgres");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to