curioustien commented on code in PR #45351:
URL: https://github.com/apache/arrow/pull/45351#discussion_r1957527737
##########
cpp/src/parquet/arrow/writer.cc:
##########
@@ -300,9 +300,9 @@ class FileWriterImpl : public FileWriter {
}
}
- Status Init() {
+ Status Init(const ArrowReaderProperties& schema_arrow_reader_properties) {
return SchemaManifest::Make(writer_->schema(), /*schema_metadata=*/nullptr,
- default_arrow_reader_properties(),
&schema_manifest_);
+ schema_arrow_reader_properties,
&schema_manifest_);
}
Review Comment:
This is a bug in the current code where the Parquet writer always use the
default arrow reader properties for its schema manifest. Instead, it should
allow callers to pass in a custom arrow reader properties if needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
