jbonofre commented on PR #290: URL: https://github.com/apache/arrow-go/pull/290#issuecomment-2667653308
Thanks ! As you removed safe-math, the `LICENSE` doesn't have to be updated. About the code copied from LLVM, it's OK in the `LICENSE` and no need to update `NOTICE` as LLVM doesn't provide a `NOTICE`. The dependency copyright doesn't have to be in `NOTICE` (`NOTICE` is to host relevant information from dependency `NOTICE`). The copyright should be in `LICENSE` with the code copied (similar to https://github.com/apache/arrow-java/blob/main/LICENSE.txt#L211). On the other hand, the project copyright should be in the `NOTICE`, and we are good here: ``` Apache Arrow Go Copyright 2016-2025 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). ``` So, @zeroshade you are good here ! Thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
