tustvold commented on PR #7141: URL: https://github.com/apache/arrow-rs/pull/7141#issuecomment-2668076245
Thank you for this PR, and especially for the tests which make it clear what this is doing. I do have one question, is this the expected behaviour? In particular when casting timestamps without a timezone to timestamps with a timezone, the conversion is done preserving the "local" time. i.e. `2021-01-01 05:45:00.000000` -> `2021-01-01 05:45:00.000000 +0500` I therefore wonder if date conversions should behave similarly `2021-01-01` -> `2021-01-01 00:00:00.000000 +0500` With the behaviour in this PR I think you would get different behaviour going `Date32 -> Timestamp(_, None) -> Timestamp(_, Some(_))`? (It might be worth testing this regardless) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
