jonded94 commented on code in PR #45471:
URL: https://github.com/apache/arrow/pull/45471#discussion_r1962059353
##########
python/pyarrow/scalar.pxi:
##########
@@ -880,12 +1348,49 @@ cdef class MapScalar(ListScalar):
for k, v in zip(arr.field(self.type.key_field.name),
arr.field(self.type.item_field.name)):
yield (k.as_py(), v.as_py())
- def as_py(self):
+ def as_py(self, *, maps_as_pydicts=None):
"""
- Return this value as a Python list.
+ Return this value as a Python list or dict, depending on
'maps_as_pydicts'.
+
+ Parameters
+ ----------
+ maps_as_pydicts : str, optional, default `None`
+ Valid values are `None`, 'lossy', or 'strict'.
+ The default behavior (`None`), is to convert Arrow Map arrays to
+ Python association lists (list-of-tuples) in the same order as the
+ Arrow Map, as in [(key1, value1), (key2, value2), ...].
+
+ If 'lossy' or 'strict', convert Arrow Map arrays to native Python
dicts.
+ This can change the ordering of (key, value) pairs, and will
+ deduplicate multiple keys, resulting in a possible loss of data.
+
+ If 'lossy', this key deduplication results in a warning printed
+ when detected. If 'strict', this instead results in an exception
+ being raised when detected.
"""
- cdef CStructScalar* sp = <CStructScalar*> self.wrapped.get()
- return list(self) if sp.is_valid else None
+ if maps_as_pydicts not in (None, "lossy", "strict"):
+ raise ValueError(
+ "Invalid value for 'maps_as_pydicts': "
+ + "valid values are 'lossy', 'strict' or `None` (default). "
+ + f"Received '{maps_as_pydicts}'."
Review Comment:
Implemented the suggested change
##########
python/pyarrow/scalar.pxi:
##########
@@ -880,12 +1348,49 @@ cdef class MapScalar(ListScalar):
for k, v in zip(arr.field(self.type.key_field.name),
arr.field(self.type.item_field.name)):
yield (k.as_py(), v.as_py())
- def as_py(self):
+ def as_py(self, *, maps_as_pydicts=None):
"""
- Return this value as a Python list.
+ Return this value as a Python list or dict, depending on
'maps_as_pydicts'.
+
+ Parameters
+ ----------
+ maps_as_pydicts : str, optional, default `None`
+ Valid values are `None`, 'lossy', or 'strict'.
+ The default behavior (`None`), is to convert Arrow Map arrays to
+ Python association lists (list-of-tuples) in the same order as the
+ Arrow Map, as in [(key1, value1), (key2, value2), ...].
+
+ If 'lossy' or 'strict', convert Arrow Map arrays to native Python
dicts.
+ This can change the ordering of (key, value) pairs, and will
+ deduplicate multiple keys, resulting in a possible loss of data.
+
+ If 'lossy', this key deduplication results in a warning printed
+ when detected. If 'strict', this instead results in an exception
+ being raised when detected.
"""
- cdef CStructScalar* sp = <CStructScalar*> self.wrapped.get()
- return list(self) if sp.is_valid else None
+ if maps_as_pydicts not in (None, "lossy", "strict"):
+ raise ValueError(
+ "Invalid value for 'maps_as_pydicts': "
+ + "valid values are 'lossy', 'strict' or `None` (default). "
+ + f"Received '{maps_as_pydicts}'."
+ )
+ if not self.is_valid:
+ return None
+ if not maps_as_pydicts:
+ return list(self)
+ result_dict = {}
+ for key, value in self:
+ if key in result_dict:
+ if maps_as_pydicts == "strict":
+ raise ValueError(
Review Comment:
Made it a KeyError
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
