wForget commented on PR #7159: URL: https://github.com/apache/arrow-rs/pull/7159#issuecomment-2671013223
> The motivation for the wrapping variants is solely performance, as they vectorise better and are therefore orders of magnitude faster. This does not apply to the division operators, I'm therefore unclear on why one would want an unchecked version, when it will be no faster Thank you for your explanation. My motivation was just to provide `div/rem` implementation similar to `add_wrapping/sub_wrapping` that does not fail when overflow occurs. That way we can easily provide consistent behavior for binary operators in Datafusion. `BinaryExpr` in Datafusion defines a `fail_on_overflow` property which when `false` means it will not fail on overflow, and there is a similar behavior in Spark. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
