pitrou commented on PR #44822: URL: https://github.com/apache/arrow/pull/44822#issuecomment-2671870838
The CI failures need fixing but, other than that, this PR is looking very good. I get a 2x improvement on some Python micro-benchmarks: * before: ```python >>> a = pa.array(([b'foobar']*100+[None])*100, type=pa.binary_view()) >>> b = a.cast(pa.binary()) >>> %timeit a.cast(pa.binary()) 136 μs ± 461 ns per loop (mean ± std. dev. of 7 runs, 10,000 loops each) >>> %timeit b.cast(pa.binary_view()) 18.4 μs ± 21 ns per loop (mean ± std. dev. of 7 runs, 100,000 loops each) ``` * after: ```python >>> a = pa.array(([b'foobar']*100+[None])*100, type=pa.binary_view()) >>> b = a.cast(pa.binary()) >>> %timeit a.cast(pa.binary()) 51.6 μs ± 256 ns per loop (mean ± std. dev. of 7 runs, 10,000 loops each) >>> %timeit b.cast(pa.binary_view()) 19.5 μs ± 458 ns per loop (mean ± std. dev. of 7 runs, 100,000 loops each) ``` (also showing the binary -> binary_view conversion for comparison) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
