kou commented on code in PR #45596:
URL: https://github.com/apache/arrow/pull/45596#discussion_r1966402623
##########
cpp/.gitignore:
##########
@@ -43,3 +43,9 @@ cmake-build-*/
*.kdev4
*.log
*.swp
+
+# meson subprojects - wrap files need to be kept to let meson download
+# dependencies as needed, but dependencies themselves should not be versioned
+subprojects/*
+!subprojects/packagefiles
+!subprojects/*.wrap
Review Comment:
```suggestion
/subprojects/*
!/subprojects/packagefiles
!/subprojects/*.wrap
```
##########
ci/scripts/cpp_build.sh:
##########
@@ -113,6 +113,7 @@ if [ "${ARROW_USE_MESON:-OFF}" = "ON" ]; then
meson setup \
--prefix=${MESON_PREFIX:-${ARROW_HOME}} \
--buildtype=${ARROW_BUILD_TYPE:-debug} \
+ -Dtests=true \
Review Comment:
```suggestion
function meson_boolean() {
if [ "${1}" = "ON" ]; then
echo "true"
else
echo "false"
fi
}
meson setup \
--prefix=${MESON_PREFIX:-${ARROW_HOME}} \
--buildtype=${ARROW_BUILD_TYPE:-debug} \
-Dtests=$(meson_boolean ${ARROW_BUILD_TESTS:-OFF}) \
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
