himadripal commented on PR #6905: URL: https://github.com/apache/arrow-rs/pull/6905#issuecomment-2676341150
@alamb #7177 is the first one for the break up case > Hi @himadripal > > I think changing this behavior is ok. Here is my suggestion > > I don't have enough context to evaluate the implications of this change and I don't think I have enough time to study it deeply given the PR's current structure > > What I suggest is: > > 1. Sparate the test reorganization into a new PR that has no behavior changes (so we can quickly verify the test refactoring is quivalent) > > Then, let's > > 1. update this PR so it has the code change and only the changes relevant to the behavior > 2. Update the title to reflect the change(s) that it makes (I think it is "Change Decimal to String conversion from rounding to truncation") > 3. Can you please clarify if this PR is intended to also support `e` notation? The title is "Fix: Support for e notation using existing parse_decimal in string to decimal conversion" but I didn't see any tests for `e` notation -- maybe this is due to the test reorganization I mention above to tackle number 1 - created #7177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
