tustvold commented on PR #7183: URL: https://github.com/apache/arrow-rs/pull/7183#issuecomment-2677984588
> Is it right to say that instead of reqwest, we now settle on I think we just depend on `http`, I don't believe we have a dependency on `hyper` > I wonder if we need the custom service type though or if we could use something like tower I went back and forth on this, the reason for preferring a custom service was the following: * Hyper actually defines its own service and doesn't use tower (as tower isn't 1.0) - https://docs.rs/hyper/latest/hyper/service/trait.HttpService.html * We need a dyn-compatible trait, at which point the existing ecosystem traits become very cumbersome * Tower is exceptionally confusing, and the `&mut self` requirement is rather obnoxious * It allows adding Debug + Send + Sync requirements easily Ultimately defining a very simple async_trait in terms of `http` and custom body implementations, seemed simpler and unlikely to paint us into a corner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
