gruuya commented on code in PR #7188:
URL: https://github.com/apache/arrow-rs/pull/7188#discussion_r1967594644
##########
arrow-flight/tests/encode_decode.rs:
##########
@@ -42,9 +42,17 @@ async fn test_empty() {
#[tokio::test]
async fn test_empty_batch() {
- let batch = make_primitive_batch(5);
- let empty = RecordBatch::new_empty(batch.schema());
- roundtrip(vec![empty]).await;
Review Comment:
The original assertion is misleading, since in `roundtrip` the empty batch
is filtered out, and so it actually asserts against an empty vector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
