linghengqian commented on issue #636: URL: https://github.com/apache/arrow-java/issues/636#issuecomment-2680324487
- @lidavidm I'm not sure if I should reply in the current issue or in #464. But considering #464 is still a draft, I tend to ask questions in the current issue. - There is apparently a formatting issue in #464 which requires the `-Dspotless.check.skip=true` parameter. - I have tested this PR at https://github.com/linghengqian/influxdb-3-core-jdbc-test/commit/8ae1aaa2fd0d715b4dbe40ca28d6f64d6b918375 . I can confirm that this PR still has a bug. The `java.time.Instant` obtained from the query is 8 hours different from the original timestamp, which is still unreasonable. ```shell sdk install java 21.0.6-ms sdk use java 21.0.6-ms git clone [email protected]:aiguofer/arrow-java.git -b improved_tz_support cd ./arrow/ mvn clean install -DskipTests -Dspotless.check.skip=true cd ../ git clone [email protected]:linghengqian/influxdb-3-core-jdbc-test.git cd ./influxdb-3-core-jdbc-test/ sdk use java 21.0.6-ms ./mvnw -T 1C -Dtest=TimeDifferenceTest clean test ``` <details> <summary>Click me to view the core logic of the unit testπ₯―π₯¨ππ§π₯π₯ππ¦ͺππ</summary> ```shell $ ./mvnw -T 1C -Dtest=TimeDifferenceTest clean test [INFO] Scanning for projects... [INFO] [INFO] Using the MultiThreadedBuilder implementation with a thread count of 16 [INFO] [INFO] ----------< io.github.linghengqian:influxdb-3-core-jdbc-test >---------- [INFO] Building influxdb-3-core-jdbc-test 1.0-SNAPSHOT [INFO] from pom.xml [INFO] --------------------------------[ jar ]--------------------------------- [INFO] [INFO] --- clean:3.2.0:clean (default-clean) @ influxdb-3-core-jdbc-test --- [INFO] Deleting /home/linghengqian/TwinklingLiftWorks/git/public/influxdb-3-core-jdbc-test/target [INFO] [INFO] --- resources:3.3.1:resources (default-resources) @ influxdb-3-core-jdbc-test --- [INFO] skip non existing resourceDirectory /home/linghengqian/TwinklingLiftWorks/git/public/influxdb-3-core-jdbc-test/src/main/resources [INFO] [INFO] --- compiler:3.13.0:compile (default-compile) @ influxdb-3-core-jdbc-test --- [INFO] No sources to compile [INFO] [INFO] --- resources:3.3.1:testResources (default-testResources) @ influxdb-3-core-jdbc-test --- [INFO] skip non existing resourceDirectory /home/linghengqian/TwinklingLiftWorks/git/public/influxdb-3-core-jdbc-test/src/test/resources [INFO] [INFO] --- compiler:3.13.0:testCompile (default-testCompile) @ influxdb-3-core-jdbc-test --- [INFO] Recompiling the module because of changed source code. [INFO] Compiling 7 source files with javac [debug target 21] to target/test-classes [INFO] [INFO] --- surefire:3.5.2:test (default-test) @ influxdb-3-core-jdbc-test --- [INFO] Using auto detected provider org.apache.maven.surefire.junitplatform.JUnitPlatformProvider [INFO] [INFO] ------------------------------------------------------- [INFO] T E S T S [INFO] ------------------------------------------------------- [INFO] Running io.github.linghengqian.TimeDifferenceTest SLF4J(W): No SLF4J providers were found. SLF4J(W): Defaulting to no-operation (NOP) logger implementation SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details. 2ζ 25, 2025 11:11:36 δΈε org.apache.arrow.driver.jdbc.shaded.org.apache.arrow.memory.BaseAllocator <clinit> δΏ‘ζ―: Debug mode disabled. Enable with the VM option -Darrow.memory.debug.allocator=true. 2ζ 25, 2025 11:11:36 δΈε org.apache.arrow.driver.jdbc.shaded.org.apache.arrow.memory.DefaultAllocationManagerOption getDefaultAllocationManagerFactory δΏ‘ζ―: allocation manager type not specified, using netty as the default type 2ζ 25, 2025 11:11:36 δΈε org.apache.arrow.driver.jdbc.shaded.org.apache.arrow.memory.CheckAllocator reportResult δΏ‘ζ―: Using DefaultAllocationManager at memory/netty/DefaultAllocationManagerFactory.class [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.419 s <<< FAILURE! -- in io.github.linghengqian.TimeDifferenceTest [ERROR] io.github.linghengqian.TimeDifferenceTest.test -- Time elapsed: 3.354 s <<< FAILURE! java.lang.AssertionError: Expected: is <2025-02-25T03:11:24.614425710Z> but: was <2025-02-24T19:11:24.614425710Z> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:8) at io.github.linghengqian.TimeDifferenceTest.queryDataByJdbcDriver(TimeDifferenceTest.java:89) at io.github.linghengqian.TimeDifferenceTest.test(TimeDifferenceTest.java:50) at java.base/java.lang.reflect.Method.invoke(Method.java:580) at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) [INFO] [INFO] Results: [INFO] [ERROR] Failures: [ERROR] TimeDifferenceTest.test:50->queryDataByJdbcDriver:89 Expected: is <2025-02-25T03:11:24.614425710Z> but: was <2025-02-24T19:11:24.614425710Z> [INFO] [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 4.894 s (Wall Clock) [INFO] Finished at: 2025-02-25T11:11:38+08:00 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.2:test (default-test) on project influxdb-3-core-jdbc-test: There are test failures. [ERROR] [ERROR] See /home/linghengqian/TwinklingLiftWorks/git/public/influxdb-3-core-jdbc-test/target/surefire-reports for the individual test results. [ERROR] See dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream. [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException ``` </details> - Or should I close the current issue and reply on #463? What I was referring to was exactly `org.apache.arrow:flight-sql-jdbc-driver:19.0.0-SNAPSHOT`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
