paleolimbot commented on code in PR #45459:
URL: https://github.com/apache/arrow/pull/45459#discussion_r1969530501
##########
cpp/src/parquet/column_writer_test.cc:
##########
@@ -399,6 +399,26 @@ class TestPrimitiveWriter : public
PrimitiveTypedTest<TestType> {
return metadata_accessor->key_value_metadata();
}
+ std::unique_ptr<ColumnChunkMetaData> metadata_accessor() {
+ // Metadata accessor must be created lazily.
+ // This is because the ColumnChunkMetaData semantics dictate the metadata
object is
+ // complete (no changes to the metadata buffer can be made after
instantiation)
+ return ColumnChunkMetaData::Make(metadata_->contents(), this->descr_);
+ }
+
+ EncodedStatistics metadata_encoded_stats() { return
metadata_stats()->Encode(); }
+
+ std::shared_ptr<Statistics> metadata_stats() {
+ return metadata_accessor()->statistics();
+ }
+
+ std::shared_ptr<GeospatialStatistics> metadata_geometry_stats() {
+ ApplicationVersion app_version(this->writer_properties_->created_by());
+ auto metadata_accessor = ColumnChunkMetaData::Make(
+ metadata_->contents(), this->descr_, default_reader_properties(),
&app_version);
Review Comment:
That was a result of the rather extensive rebase on top of the size
statistics change 😬
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
